search

coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.
https://coolify.io
Apache License 2.0
34.62k stars 1.89k forks source link

[Bug]: Webhook deployments from git commits don't respect [skip ci] #4357

Closed sisou closed 20 hours ago

sisou commented 22 hours ago

Error Message and Logs

For CIs it has been established as a standard to be able to put [skip ci] somewhere in a commit message to tell the CI to not run with this commit.

I noticed earlier that deployments by webhook for, in my case, Github pushes still trigger deployments in Coolify.

I think they should be skipped when [skip ci] is found in the commit message.

It's also ok to introduce another keyword.

Steps to Reproduce

  1. Push a commit to a auto-deployed repo with [skip ci] in the commit message
  2. Observe that any configured Github Actions do not run for this commit
  3. Observe that Coolify still deploys the commit

Example Repository URL

No response

Coolify Version

v4.0.0-beta.370

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Ubuntu 22.04.5 LTS

Additional Information

No response

peaklabs-dev commented 20 hours ago

This is more of an improvement request as it has not yet been implemented, so I am moving this to a GitHub discussion.