coollabsio / fonts

A privacy-friendly drop-in replacement for Google Fonts
https://fonts.coollabs.io
Apache License 2.0
405 stars 14 forks source link

[bug] 500 error for special italic convention: "ital@0;1" #1

Closed spencerflagg closed 2 years ago

spencerflagg commented 2 years ago

When generating <link>s for this font, you get a syntax convention that's new to me: "ital@0;1". :man_shrugging: Seems to fail on Cool's server.

google's: https://fonts.googleapis.com/css2?family=DM+Serif+Display:ital@0;1&display=swap

cool's: https://api.fonts.coollabs.io/css2?family=DM+Serif+Display:ital@0;1&display=swap

{"statusCode":500,"error":"Internal Server Error","message":"undefined is not iterable (cannot read property Symbol(Symbol.iterator))"}
andrasbacsai commented 2 years ago

Uh, I missed this issue! I will take a look!

andrasbacsai commented 2 years ago

It's fixed! Let me know if it still not good!

zoeleu commented 2 years ago

still not fixed!

Try this: https://fonts.googleapis.com/css2?family=Gentium+Book+Plus:ital@1&family=Montserrat:wght@100;300;400;500;700;900&display=swap

Versus this: https://api.fonts.coollabs.io/css2?family=Gentium+Book+Plus:ital@1&family=Montserrat:wght@100;300;400;500;700;900&display=swap

andrasbacsai commented 2 years ago

Nice catch! I fixed it! Please check it!

zoeleu commented 2 years ago

it's working now