search

coolmodi / SpellCalc

A WoW classic addon providing information for spells, like actual damage done, crit and hit chance, scaling etc.
43 stars 8 forks source link

Missing actionbar values #48

Open merijn opened 1 year ago

merijn commented 1 year ago

A number of my action bar buttons don't seem to be getting a predicted "avg value" showing (see screenshots). Some of these are macros (but some other macros show fine) and some are HOTs/DOTs (but not all of them), so I'm a bit lost why this happens. Missing in the screenshot are: Damage/heal values for Shadow Word: Death, Shadow Word: Pain, Devouring Plague, Renew, Flash Heal, Holy Fire, and Desperate Heal.

Note also that the values show on actionbars don't seem to update if/when the spells show do. Action button 2-4 show the heal values of buttons in that position in my "friendly" action bar (hidden because I have a hostile target), rather than updating and showing the damage values for the active action bar's spells.

image

merijn commented 1 year ago

Ah! I think I have identified the issue. The detection for Dominos is broken when using the latest Dominos, since it was overhauled for retail in Dragonflight. Specifically, these lines: https://github.com/coolmodi/SpellCalc/blob/wotlk/UI/actionbar/buttonText.lua#L197-L199 never run with recent Dominos loaded, since button 1 is just ActionButton1.

By changing it to check for DominosFrame1, instead of DominosActionButton1 the detect is "fixed", but the creation of font strings for some of dominos buttons is still broken and I haven't quite figured out why yet.

merijn commented 1 year ago

As far as I can tell fontstrings are properly created for all the action buttons, however only the fontstrings for the stock bars are actually updated to show info.