coolshou / thumbnailator

Automatically exported from code.google.com/p/thumbnailator
Other
0 stars 0 forks source link

Content assist in Eclipse does not show the correct argument names #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Problem
-------
* When using the content assist (pressing Ctrl-Space in Windows) with the 
`Thumbnails` builder interface, the method argument names appear as `arg0`, ... 
, `argn` rather than the actual argument name.

* The issue is with a bug in Eclipse which cannot provide content assist for 
inner classes correctly.
 * https://bugs.eclipse.org/bugs/show_bug.cgi?id=151500
 * The issue is to be fixed in Eclipse 3.7, according to the above ticket.

Solution
--------
* Move the `Thumbnails.Builder` inner class to a top-level class.
 * Although the bug is to be fixed in the next release of Eclipse, one cannot reasonably expect that all users will transition to the new version.
 * Solving this problem is in the interest of Thumbnailator users, as it decreases the user-friendliness of the library.

Complications
-------------
* It has the potential to break non-standard usage of the API, such as code 
which is assigning the `Thumbnalis.Builder` object to a variable:

  // The following code will break:
  Thumbnails.Builder builder = Thumbnails.of(...);

Original issue reported on code.google.com by coobird...@gmail.com on 21 Mar 2011 at 10:08

GoogleCodeExporter commented 9 years ago
Eclipse Indigo (3.7) has addressed the issue, and now correctly displays the 
argument names of methods in inner classes.

Attached are images which show the results of the Content Assist on the 
`Thumbnails.Builder` instance from Eclipse Helios (3.6) and Eclipse Indigo 
(3.7).

Original comment by coobird...@gmail.com on 25 Jun 2011 at 2:58

Attachments:

GoogleCodeExporter commented 9 years ago
I'll be closing this issue, as:

 * There's very little interest in this problem.
 * It only affects users with a copy of Eclipse from over 2 years ago.
 * Only the argument names are affected, so it's only a nuisance rather than a problem.

Original comment by coobird...@gmail.com on 11 Feb 2012 at 6:31