search

cooltronicpl / Craft-document-helpers

Craft CMS 3 and 4, 5 alpha, beta plugin enabling PDF document generation from template Twig files, code blocks and URLs
Other
12 stars 6 forks source link

date option not working #19

Closed d-karstens closed 9 months ago

d-karstens commented 11 months ago

Hi,

We've run into an issue where our PDF files are not updating when using the date option on version 1.2.5

I believe it's because of the $attributes['date'] ?? false check on this line https://github.com/cooltronicpl/Craft-document-helpers/blob/master/src/variables/DocumentHelperVariable.php#L51C16-L51C16

Changing it to isset($attributes['date']) like it used to be in an older version seems to work

Thanks!

cooltronicpl commented 10 months ago

Please try now in 1.3.0 for v4 and 0.4.0 for v3 also we made other changes that caused a problem in the code because the exact change caused a problem when we used the header and the footer in PDFs in some of our tests.

d-karstens commented 10 months ago

Yep, it's working for us on version 1.3.0 :+1: Thank you for the fix!