Give canvas tag an explicit size.

coolwanglu / neovim-e

Electron UI for Neovim

MIT License

271 stars 29 forks source link

Give canvas tag an explicit size. #13

Closed rygwdn closed 9 years ago

rygwdn commented 9 years ago

Fixes #8

Set the size in px of the canvas during resize. This avoids having the canvas stretch when the size of the window does not exactly line up with the expected size.
When handling a resize, only change the size of the window if the window size doesn't match what is expected for the current number of rows/columns
Fill the background of the window with the theme background color

coolwanglu commented 9 years ago

Do you mean that sometimes the size of a window does not respect to the parameters to window.resize ?

rygwdn commented 9 years ago

It works fine when window.resizeTo is called, but when it's not called the canvas gets stretched. It doesn't get called if the window is resized by the mouse but doesn't change the number of rows or columns. This happens pretty consistently for me if I drag the window corner, hold it for a moment, then let go - the window size changes by a few pixels between when I stopped trying to move the cursor and when I let go.

coolwanglu commented 9 years ago

I tried your patch, which works fine. Thanks!