search

coolwanglu / neovim-e

Electron UI for Neovim
MIT License
271 stars 29 forks source link

Use CSS to make cursor blink. #25

Closed rygwdn closed 9 years ago

coolwanglu commented 9 years ago

That's a good idea! Can you make an option for this?

In the future, probably the cursor will be re-implemented as a solid box, with inversed color.

rygwdn commented 9 years ago

@coolwanglu: I added a config option for it. I started down the road of a more complicated cursor re-design, but decided to take this as a quick win for now. I'd like to support 'guicursor', but that needs the cursor to be drawn on the canvas instead of in a div (to support doing the optional inverse).

coolwanglu commented 9 years ago

@rygwdn Yes, I had thought of that, and in fact I was trying to draw the cursor on canvas in the first place. The problem is that we need to know the character and attrs under the cursor, but we cannot do that without saving the entire buffer. The Python client is doing this way, but I don't like to store the text.

Feel free to move cursor on the canvas.

coolwanglu commented 9 years ago

Merged. Thanks!