search

coolwanglu / neovim-e

Electron UI for Neovim
MIT License
271 stars 29 forks source link

Pause blinking when moving the cursor or interacting with the mouse. #42

Closed trusktr closed 9 years ago

trusktr commented 9 years ago

Does that look better? How would you use the fat arrow function?

trusktr commented 9 years ago

There we go! Used the arrow function. :D

coolwanglu commented 9 years ago

Thanks for the PR.

Regarding _ and debounce, I think it's better to make a very simple implementation here (just a timer and an extra call to setTimeout), instead of the wrapper. We don't want to pollute the namespace here.

I don't use blinking cursors myself, yet I do agree that it should stop blinking when moving very fast. But why also for mouse events? It doesn't look like obvious to me.

trusktr commented 9 years ago

why also for mouse events?

Any time we interact with the cursor it's nice to see it. Any time we don't interact with it, the blinking helps us find it. Some would also like extra settings for blinking only in INSERT mode, etc.

coolwanglu commented 9 years ago

@trusktr OK I think I agree with you about holding the cursor blinking.

trusktr commented 9 years ago

There we go, how does that look?

trusktr commented 9 years ago

Alright, there we go.

coolwanglu commented 9 years ago

Merged.

Thanks a lot!

trusktr commented 9 years ago

Awesome! :smile: