search

coomar2841 / image-chooser-library

An Easy Image/Video Chooser Library for your Android Apps
646 stars 192 forks source link

What about crop image? #10

Closed hidabe closed 9 years ago

hidabe commented 11 years ago

I am thinking about add crop image with https://github.com/lvillani/android-cropimage

Where could i add it?

dmitry-kopitkov commented 10 years ago

Hi,

I'm interested in this too. Can it be added?

Thanks, Dmitrty

mykola-dev commented 10 years ago

+1

timmolter commented 10 years ago

+1

fraserscottmorrison commented 10 years ago

++

coomar2841 commented 10 years ago

Thanks for the request. Will look into this soon. :)

timmolter commented 9 years ago

How about integrating this to do the cropping?

jagatappv commented 9 years ago

+1 i am also waiting for this.. :D

coomar2841 commented 9 years ago

Ok, Will be adding it in the next release. Probably in a week.

coomar2841 commented 9 years ago

On second thoughts, can't the application directly use that library? It's pretty easy to integrate it with your apps. I don't see a reason why I should either re-write or re-package this library with this ICL library.

jagatappv commented 9 years ago

It would be good for user to use single library instead of handling two separate one.

timmolter commented 9 years ago

@coomar2841 That's actually what IU ended up doing.

coomar2841 commented 9 years ago

I understand that. But then, I would also be tempted to integrate other image handling libraries. The other libraries already do an amazing job and when they would update their libraries to add new features or bug fixes, I would also have to release ICL again, although I haven't made any changes to ICL code. People, eventually, who would have bugs in the older version, would probably end up using the updated library separately.

coomar2841 commented 9 years ago

@timmolter Nice :+1:

Jaymassena commented 9 years ago

My 2 cents. Image chooser should be great at picking media and that's it. Packing in more is a slippery slope that never ends.

coomar2841 commented 9 years ago

Closing this now.