search

coomar2841 / image-chooser-library

An Easy Image/Video Chooser Library for your Android Apps
646 stars 193 forks source link

add support to choose image or video from gallery #22

Closed dmitry-kopitkov closed 10 years ago

dmitry-kopitkov commented 10 years ago

ok, i hope i did this "pull request" right.. anyway, please review my code and merge it.

there is one part of my handling that i'm not sure about - MediaChooserManager, line 214 there i'm checking if selectd content is video or image. method "wasVideoSelected" was working in all cases that I've checked, but still if u have better idea, please improve the code.

regards, Dima

coomar2841 commented 10 years ago

Will have a look.

Thanks and Regards,Kumar Bibek

http://techdroid.kbeanie.com http://techdroid.kbeanie.comhttp://www.kbeanie.com http://www.kbeanie.com

On Mon, Mar 10, 2014 at 3:34 PM, dimka-kopitkov notifications@github.comwrote:

ok, i hope i did this "pull request" right.. anyway, please review my code and merge it.

there is one part of my handling that i'm not sure about - MediaChooserManager, line 214 there i'm checking if selectd content is video or image. method "wasVideoSelected" was working in all cases that I've checked, but still if u have better idea, please improve the code.

regards, Dima

Reply to this email directly or view it on GitHubhttps://github.com/coomar2841/image-chooser-library/pull/22#issuecomment-37167359 .

coomar2841 commented 10 years ago

Started looking into it. Testing with various OS versions and phones. Currently, all the relevant changes are in a separate branch. Also, updating the sample app to use this.