coomar2841 / image-chooser-library

An Easy Image/Video Chooser Library for your Android Apps
646 stars 193 forks source link

Null Data on 4.4.3 for Capture #35

Closed jschleppy closed 10 years ago

jschleppy commented 10 years ago

There's a reported issue with EXTRA_OUTPUT being ignored or something on 4.4.3. See here: https://code.google.com/p/android/issues/detail?id=71380

After upgrading my phone's ROM to 4.4.3, I can confirm that all I get from this library is a callback to onError() from library listener, stating that it's corrupt or deleted. Return result is still RESULT_OK in onActivityResult, data is just null.

coomar2841 commented 10 years ago

Can I reproduce this with any device on 4.4.3?

jschleppy commented 10 years ago

I wonder the same thing. I've only tested on a Galaxy S4, running specifically this ROM: http://forum.xda-developers.com/showthread.php?t=2537495 (4.4.3 for now). Not sure knowing that will help all that much, but it's pretty vanilla Android.

I have a co-worker who is on 4.4.3 Nexus 5 that I can have test first thing tomorrow in office. Hopefully he didn't take that 4.4.4 OTA upgrade just yet. Though, that Google code issue is posted from a Nexus 5 device, so I assume it would have the same issue.

Unfortunately I don't have access to any other 4.4.3 devices.

coomar2841 commented 10 years ago

Ok, Will look into this on a few devices, and try to reproduce this. Thanks for the issue.

jschleppy commented 10 years ago

Yeah, sorry I wasn't of much help, my co-worker has already upgraded to 4.4.4, as have I now, but the problem still exists.

jschleppy commented 10 years ago

I happened to fix my issue and it's neither a problem with your SDK or the new OS version, but instead a file path issue. I am using sub folders for a more organized arrangement than the sample app shows, such as "app_name/temp/photos" and "app_name/temp/videos". In passing my file path, I wrote them as "app_name//temp//photos" and "app_name//temp//videos". I went diving through your source and saw you wrote your own using File.separator and opted to switch mine out instead of using "//". And just like that it started working! Sorry if you wasted anytime with this. Closing ticket.

coomar2841 commented 10 years ago

Great. No problems. Didn't spend much time on it.