cooncesean / mixpanel-query-py

The Python interface to fetch data from Mixpanel.
MIT License
29 stars 17 forks source link

fixes a unicode/string bug in the raw data export client method #21

Closed thesmallestduck closed 8 years ago

thesmallestduck commented 8 years ago

why

when using the get_export method, you are supposed to pass an array of event names for mixpanel to pull. Our method was generous and tried to detect a singleton event name and auto-wrap it in an array. Unfortunately, it only looked for a string, so if a unicode event name was passed in, a bad request was generated to mixpanel, since mixpanel requires the passed event argument be a url encoded json array.

what

broadens a check from checking if a string is provided to check instead is a non-None, non-array provided

frifri commented 8 years ago

Thanks.