search

cooncesean / mixpanel-query-py

The Python interface to fetch data from Mixpanel.
MIT License
29 stars 17 forks source link

Fix bukets typo #5

Closed hmarr closed 9 years ago

hmarr commented 9 years ago

Noticed a minor typo.

cooncesean commented 9 years ago

Nice catch; so I take it the get_segmentation_numeric() method is currently not working as expected?

hmarr commented 9 years ago

To be honest, I haven't tried it - I'm only working with the people engage and export APIs (expect more PRs!)

I just noticed the typo, and checked it doesn't match up with what's in the docs.

cooncesean commented 9 years ago

Right on, thx for the patch!

I can't imagine it was working before, but we never had to use this method internally, so it was never formally tested.... I should probably start adding some unit tests.

cooncesean commented 9 years ago

FYI - The version number has been bumped to 0.1.2 and uploaded to PyPi and you have been added to the list of contributors -- thanks for helping out :)