search

cooncesean / mixpanel-query-py

The Python interface to fetch data from Mixpanel.
MIT License
29 stars 17 forks source link

Add get_engage method to Client #6

Closed hmarr closed 10 years ago

hmarr commented 10 years ago

Support for the engage API. Tested locally, seems to work.

As the response is paginated, we've also written a helper class for concurrently fetching all pages. If this is of interest, I'm happy to submit a PR for that.

cooncesean commented 10 years ago

Re: Pagination: That would be great if you want to add it to the library. Maybe as a separate module pagination.py? If there are a lot of other patches/features you plan on working on, let me know and I can just add you as a contributor.

hmarr commented 10 years ago

Sure, will do. It's a totally self-contained class so fits naturally in its own module.

There are a few more things I'm planning on adding, so being a contributor may be easier. I'll still put changes through pull requests so you get a chance to check things over.

cooncesean commented 10 years ago

Added; I'll merge this PR. Let me know when you finish up and I'll bump the version number and push to PyPi.

Thanks again, this is all super helpful :)

hmarr commented 10 years ago

Awesome, thanks - happy to help.