search

coop-care / paid

PAID is library for care billing with payers in Germany according to § 105 SGB XI and § 302 SGB V. The project name is an acronym and stands for "Pflegeabrechnung in Deutschland".
GNU Lesser General Public License v3.0
10 stars 3 forks source link

billing sample data #17

Closed michaelkamphausen closed 3 years ago

michaelkamphausen commented 3 years ago

Closes #7 and #9.

michaelkamphausen commented 3 years ago

Also includes payload data validation according to #18, but only for SGB XI yet.

michaelkamphausen commented 3 years ago

Thank you for reviewing! Do you approve the PR with my changes and answers?

westnordost commented 3 years ago

Maybe one thing, I figure that could be done later. You have some utility functions like forEachKostentraeger and something like that, but those return a result. I wouldn't expect a function named like that to return a result. Depending on what the function does exactly, maybe map(Each)Kostentraeger would fit better?

michaelkamphausen commented 3 years ago

I see your point. Okay, let's call it mapEachKostentraeger. I know the name was misleading and I chose it to align the lines 54 – 64 with the documentation on pages 12 - 14, but I think mapEach… is better now.