search

coop-care / paid

PAID is library for care billing with payers in Germany according to § 105 SGB XI and § 302 SGB V. The project name is an acronym and stands for "Pflegeabrechnung in Deutschland".
GNU Lesser General Public License v3.0
10 stars 3 forks source link

parse also the groups, subgroups etc from hilfsmittelverzeichnis xml #42

Closed westnordost closed 3 years ago

westnordost commented 3 years ago

I also changed the data structure for HilfsmittelProduct to include group id, subgroup id etc. as own fields but supplied a helper function getPositionsnummer. I hope this is useful.

If you build an index for these to be used in the UI, I think this part could still be put into the library instead of the UI (coop-care).

To answer your question regarding a "Produktbesonderheit" field: No, something like that does not exist. I documented in the code all fields that are not parsed.

You mentioned you'd put this data into an index.db?

I could write a converter that writes the SQL to insert this into a SQL database if you like. The resulting hilfsmittelverzeichnis.sql file would also be considerably smaller than the json.

michaelkamphausen commented 3 years ago

Looks good!

I store the data in an IndexedDB, and as far as I know one cannot insert SQL. The idea is nice though.

Nevertheless the current implementation is good enough. And I think we can skip the Produktbesonderheit Kennzeichen. I learned today that home care providers rarely bill Pflegehilfsmittel, so I think we should not improve or optimize further and move on. I wish I knew that earlier, but anyway I think it's useful we have the Pflegehilfsmittelverzeichnis in our library.

westnordost commented 3 years ago

I store the data in an IndexedDB, and as far as I know one cannot insert SQL. The idea is nice though.

Oh, I see. Skimming through the documentation, it looks like the interface to indexedDB is pretty much json-based

I learned today that home care providers rarely bill Pflegehilfsmittel, so I think we should not improve or optimize further and move on. I wish I knew that earlier

Maybe they don't because it is complicated to do so? But anyway, I at least didn't spend so much time on this anyway, as you see, the code is very small and the parsing is straightforward.