coop-deluxe / sm64coopdx

An official continuation of https://github.com/djoslin0/sm64ex-coop on sm64coopdx for the enhancements and progress it already has.
https://sm64coopdx.com
286 stars 41 forks source link

Add Mod Categories #214

Open EmeraldLoc opened 1 month ago

EmeraldLoc commented 1 month ago

Needs translation, I don't trust google translate with any of these.

This adds categories to the mod selector. It'll attempt to use a new category header from Lua. This can be set to, say, -- category: gamemodes. If the category is NULL, it defaults to using the incompatible header, however this gives some quirks (some mods showing up in multiple categories).

A place I'm not a fan of is line 172 and onwards of djui_panel_host_mods.c. Currently creates a bool and checks that, which I'm not a fan of, however I believe the only alternative is using goto. If there's a better solution lmk, otherwise, semi-happy with this :D.

EDIT: Here's a video of it in action!

https://github.com/user-attachments/assets/52662693-5bd8-4344-8663-50c3bb7c1bcc

SuperKirbylover commented 1 month ago

this is awesome!!! as a sucker for categorization i would love to have this! a character select category would be nice, but that's just my own thought lmao i'd also love this kind of organization in a file level, where there's subfolders for them instead of the singular "mods" folder, but that might take some extra work. i just ask for it since i have a lot of mods and scrolling through them in my files gets a smidge overwhelming

EmeraldLoc commented 1 month ago

a character select category would be nice, but that's just my own thought

Ye I did think about this, each mod would require a category tag, which I can add to the builtin ones, however was gonna leave that up to the devs.

i'd also love this kind of organization in a file level, where there's subfolders for them instead of the singular "mods" folder

Not necessarily related to the pr, however yea this would be sick! Maybe make that as an issue for a enchantment, that way the dev's can look on it, and acknowledge it.

Isaac0-dev commented 1 month ago

the video does not work for me, is anyone else having that trouble?

EmeraldLoc commented 1 month ago

Not having the problem, here's a youtube link, which should hopefully work lol.

AgentXLP commented 1 month ago

You should make an All category

Mariosonicman91 commented 3 weeks ago

a character select category would be nice, but that's just my own thought

Ye I did think about this, each mod would require a category tag, which I can add to the builtin ones, however was gonna leave that up to the devs.

i'd also love this kind of organization in a file level, where there's subfolders for them instead of the singular "mods" folder

Not necessarily related to the pr, however yea this would be sick! Maybe make that as an issue for a enchantment, that way the dev's can look on it, and acknowledge it.

Not necessarily, couldn't you refer to the incompatible tab to detect if it's a Rom Hack or game mode?

EmeraldLoc commented 3 weeks ago

Oh yea. What I meant was for character select mods, it would require a category tag, since they don’t really have an incompatible one. The category system does fallbacks on incompatible tags, which works pretty well.

Mariosonicman91 commented 3 weeks ago

You're right.