search

coop-deluxe / sm64coopdx

An official continuation of https://github.com/djoslin0/sm64ex-coop on sm64coopdx for the enhancements and progress it already has.
https://sm64coopdx.com
408 stars 73 forks source link

Memory corruption #301

Closed SonicTheHedgeHog64 closed 1 month ago

SonicTheHedgeHog64 commented 2 months ago

Describe the bug I can't host a lobby if i've already been in one, and it just crashes my game To Reproduce Steps to reproduce the behavior: Get Peaches Fury Join a random lobby, Play around in it Exit the lobby Host Peaches Fury

Expected behavior I can host the lobby, Nothing crashes Screenshots Screenshot from 2024-09-05 12-09-17

Desktop (please complete the following information):

Additional context There's scrolling textures in the romhack

SonicTheHedgeHog64 commented 2 months ago

(The user was in another lobby)

AgentXLP commented 2 months ago

This looks like memory corruption, @Isaac0-dev what do you think Edit: Just saw, the "game tried to read unmapped memory" part, yeah, I think this is an smlua related crash.

Isaac0-dev commented 2 months ago

the link doesn't work, I'd like to test the crash myself if I can.

AgentXLP commented 2 months ago

Peach-Fury-Port.zip

SonicTheHedgeHog64 commented 2 months ago

Agent sent another link

On Fri, Sep 6, 2024, 7:56 PM Isaac0-dev @.***> wrote:

the link doesn't work, I'd like to test the crash myself if I can.

— Reply to this email directly, view it on GitHub https://github.com/coop-deluxe/sm64coopdx/issues/301#issuecomment-2334977266, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2BZ7Z23IMGZHLKCTVBT463ZVJFKRAVCNFSM6AAAAABNW6LR7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUHE3TOMRWGY . You are receiving this because you authored the thread.Message ID: @.***>

Isaac0-dev commented 2 months ago

I haven't been able to reproduce the bug despite following those instructions given. I also tried other things and no success. Also until I see more information about this crash I don't see any way that this could be related to smlua. It could be memory corruption, but it could also just be a read out of bounds.

SonicTheHedgeHog64 commented 1 month ago

figured out why it crashed

go into the mod

go into the water

stop the lobby

rehost

see the crash

genuinely my fault.

SonicTheHedgeHog64 commented 1 month ago

THE WAY I DID IT ALSO EXACTLY MATCHES THE CRASH SCREEN DOWN TO THE READ OOB TO THE STACK TRACE WTF