coop-deluxe / sm64coopdx

An official continuation of https://github.com/djoslin0/sm64ex-coop on sm64coopdx for the enhancements and progress it already has.
https://sm64coopdx.com
343 stars 59 forks source link

Mod save files get completely wiped when having mutiple windows of coop open #319

Open TheMan6900 opened 1 week ago

TheMan6900 commented 1 week ago

uh yeah, this probably should be fixed lel.

frog8412 commented 1 week ago

Settings are saved when the game is closed, so opening 2nd window and then closing 1st one, then the 2nd one results in 2nd window's settings overwriting 1st window's settings

EmeraldLoc commented 1 week ago

I know what he is taking about, however I’ve failed to reproduce it. How are you reproducing the bug?

TheMan6900 commented 1 week ago

I just had two windows open, with both connected to a private server, also with the tag gamemode applied. Did some matches then once I closed the window hosting the server. Boom! Tag save file dead.

EmeraldLoc commented 1 week ago

Yea I’m unable to reproduce if I don’t use tag, so I don’t know the root cause. This does not happen if you use the old save system that used ConfigFile, so I assume it has to do with mIni.

TheMan6900 commented 1 week ago

the mod save file thing should be fixed in it of itself so, gonna rename it to just that until I find a clear way to do this with coop settings (Rip 180 runner, and 97 tagger wins 😭)