search

coop-deluxe / sm64coopdx

An official continuation of https://github.com/djoslin0/sm64ex-coop on sm64coopdx for the enhancements and progress it already has.
https://sm64coopdx.com
408 stars 73 forks source link

Add some suggestions from issues #354

Closed Sunketchupm closed 1 month ago

Sunketchupm commented 1 month ago

Each commit is a different suggestion. Specifically, issues #343, #349, and #264. One of the suggestions doesn't come from an issue but still something I heard about and wanted to make.

Cooliokid956 commented 1 month ago

is there a reason why the coopnet id function was limited to only the local player's id? the issue didn't narrow it down to only the local id

Sunketchupm commented 1 month ago

The reason is that this is based almost entirely on the get discord id function. There's no real reason otherwise though, so I'll change that.

Cooliokid956 commented 1 month ago

if you didn't notice, the original discord id function was undeprecated a while ago, now discord ids are networked

Sunketchupm commented 1 month ago

Surprised no one mentioned the pvp damage changes that were suggested. I talked with saus and theman, both of whom do a lot of pvp, and they think this is good. However I would like some other opinions on it since it will change pvp a lot.

EmeraldLoc commented 1 month ago

PvP changes are generally good. Punches should 100% do more damage, so it’s good it does that now. The only thing that I feel like could be iffy is the slide kick, but that’ll take some tinkering. Also I don’t know how I feel about the dive thing, while it does make sense, dives having good kickback feels pretty broken, once again takes some testing.