search

coop-deluxe / sm64coopdx

An official continuation of https://github.com/djoslin0/sm64ex-coop on sm64coopdx for the enhancements and progress it already has.
https://sm64coopdx.com
403 stars 71 forks source link

Raycast Step Implementation #498

Open theclashingfritz opened 1 week ago

theclashingfritz commented 1 week ago

A raycast based step implementation based off Kaze Emanuars raycasted step system.

This PR has a couple of things to do before merge:

  1. Testing, You can toggle it on with gBehaviorValues.MarioRaycastSteps which is False by default.
  2. Cleanup on the code styling to be inline with the rest of the game,
  3. Figure out if Kaze Emanuar is okay with this being in Co-Op at all.

Besides those things. This PR should be ready. Feel free to discuss remarks or any other things.

Sunketchupm commented 1 week ago

I found a few bugs playtesting this

Wallkick from any angle https://github.com/user-attachments/assets/c2291d88-fb18-4cf1-afbe-18f6b2dc61ee

This mild upwarp oddity on bonk https://github.com/user-attachments/assets/5f0d9ae6-582c-4df1-95b5-ad08071cecbc

Ledge oddity here, unable to ledgegrab and mild upwarp https://github.com/user-attachments/assets/86d08dc3-00cb-4637-b9e0-5b5893a9358d Other ledge oddities I found https://github.com/user-attachments/assets/0dbf4acf-f7aa-4399-b215-0a06ec3fe79e https://github.com/user-attachments/assets/d85a2cab-1d42-4026-af65-9d3b50cad442 https://github.com/user-attachments/assets/d4d13d5a-f5fe-48d2-96e4-77e242de3417 https://github.com/user-attachments/assets/b145fd81-3b63-4eb0-91de-0441e94b11c1

The whomp king normally cannot be clipped through like this in this way https://github.com/user-attachments/assets/9a3cb3ea-6dd8-4fc5-bb0e-3fcb0a49811b Another rising platform clip https://github.com/user-attachments/assets/589014c5-7e2d-4b57-9cfe-2c1613d2939a

Small upwarp on this pillar, though kind of hard to see https://github.com/user-attachments/assets/874c9c43-1af7-4237-ac0e-e910c4a50189

Unable to jump here https://github.com/user-attachments/assets/dbd09e60-7b4b-464e-844a-6d1a85257907

theclashingfritz commented 6 days ago

Thank you for the playtest! You did find some really weird oddities so thank you. It looks like the wallkicks thing is similar to a glitchy wallkick-I wonder if those are fixed it'd stop doing that.

The spot you're unable to jump in front of DDD, I don't think there is a fix for. It looks like it may be exposed OOB which is likely normally skipped by the older systems quartersteps.

Any rising platform clip is unintended so thanks for pointing them out. Same for the weird Whomp King clip.

I'll also look into the weird ledgegrabs