search

coop182 / jquery.dfp.js

A jQuery implementation for Google DoubleClick for Publishers (DFP)
MIT License
278 stars 91 forks source link

Add support to detect ghostery and/or adblock-plus #110

Closed BowlingX closed 9 years ago

BowlingX commented 9 years ago

This pull requests will add support to detect current versions of adblock-plus and ghostery. There will be a new event available afterAdBlocked. It's called for each ad separately.

I successfully tested it with adblock plus in chrome/firefox and ghostery. The dfpBlocked Method is not called because the load of the base ad script is successful in current implementations.

soreng commented 9 years ago

The problem we see most ad-blockers cause, is blocking the script from being loaded, so the whole anti-ad-blocking never even gets to the user.

In order to get around that issue, the jquery.dfp could be bundled with other crucial scripts, so user with ad-blockers, will not be able to use the page as intended, or maybe not at all.

It is a battle that is very hard to win, but then again it's not a battle that developers will win - we just make the weapons for both sides :-)

If "supports ad-blockers" really should be part of jquery.dfp, it would be a whole other project.

But a comment to the work done; great, I love seeing so many (new) people contributing :-)

(Sorry for the rant)

On 23. sep. 2015, at 17.14, David Heidrich notifications@github.com wrote:

This pull requests will add support to detect current versions of adblock-plus and ghostery. There will be a new event available afterAdBlocked. It's called for each ad separately.

I successfully tested it with adblock plus in chrome/firefox and ghostery. The dfpBlocked Method is not called because the load of the base ad script is successful in current implementations.

You can view, comment on, or merge this pull request online at:

https://github.com/coop182/jquery.dfp.js/pull/110

Commit Summary

Add event listener for ads that have been blocked by adblocker Better adblock detection Add support to detect either ghostery and/or adblock-plus extensions add missing parameters File Changes

M Readme.markdown (9) M jquery.dfp.js (47) Patch Links:

https://github.com/coop182/jquery.dfp.js/pull/110.patch https://github.com/coop182/jquery.dfp.js/pull/110.diff — Reply to this email directly or view it on GitHub.

BowlingX commented 9 years ago

I don't like most of the ads today, they slow down the sites and I'm pretty sure that 80% are clicking on it by accident, especially on mobile devices. I have one argument that supports adding this functionality, and thats "Design". Some blockers also remove the parent containers (or put them to display:none), and you end up having a site that looks strange because the space that is occupied by a banner will be empty and a white surface. Eventually your site looks cluttered. If you are able to detect that an ad has been blocked, you can at least provide a fallback for the empty space.

coop182 commented 9 years ago

Sorry for the slow response to this... very busy week!

I will take a look at this shortly - it looks like a good change I just want to do a bit of testing myself. I agree with @soreng in that I don't think we want to get into a back and forth war with the various ad blockers out there. Then again we have always provided a least basic ad blocker detection as part of this script so it makes sense to at least update that to keep it working - I'm not sure how many people use it... but as long as it doesn't make this script too heavy I think its worth having.

BowlingX commented 9 years ago

Any new update/opinion on this?

coop182 commented 9 years ago

Sorry for the delay... all merged now :smile: