search

coopTilleuls / CoopTilleulsAclSonataAdminExtensionBundle

ACL list filtering for SonataAdmin
http://les-tilleuls.coop
MIT License
45 stars 21 forks source link

"Sonata\AdminBundle\Admin\AdminExtension", extended by "CoopTilleuls\Bundle\AclSonataAdminExtensionBundle\Admin\AclAdminExtension", deprecated in "sonata-project/admin-bundle": "3.x-dev" with Symfony 3.3.10 #27

Closed olivsinz closed 6 years ago

olivsinz commented 6 years ago

The "CoopTilleuls\Bundle\AclSonataAdminExtensionBundle\Admin\AclAdminExtension" class extends "Sonata\AdminBundle\Admin\AdminExtension" that is deprecated since version 3.1, to be removed in 4.0. Use Sonata\AdminBundle\AbstractAdminExtension instead

capture d ecran de 2017-12-26 15-08-25

dunglas commented 6 years ago

It needs an update. Would you mind opening a Pull Request?

As we want to support both 3.x and 4.x, you'll probably need to conditionally define the inherited class like this:

if (class_exists(AbstractAdminExtension::class)) {
    abstract class InternalAbstractClass extends AbstractAdminExtension {}
} else {
    abstract class InternalAbstractClass extends AdminExtension {}
}

class AclAdminExtension extends InternalAbstractClass
{
  // ...
}
olivsinz commented 6 years ago

Ok I am working on it

dunglas commented 6 years ago

Thanks!

olivsinz commented 6 years ago

You're welcome.