search

coopTilleuls / CoopTilleulsCKEditorSonataMediaBundle

Integrates SonataMediaBundle for Symfony with CKEditor
http://les-tilleuls.coop
MIT License
53 stars 41 forks source link

Merge this code into SonataMediaBundle #1

Closed rande closed 10 years ago

rande commented 11 years ago

Why not adding this code into SonataMediaBundle ?

The behat code can be also added to the sandbox like other functional tests

dunglas commented 11 years ago

I'm ok with that but it will introduce a (soft) dependency to CKEditor and IvoryCKEditorBundle to SonataMediaBundle. Maybe should we leave the choice to use any editor with the corresponding extension. In the other hand, adding at least TinyMCE support to this code should be easy.

rande commented 11 years ago

The SonataFormaterBundle also uses IvoryCKEditorBundle, so from a sonata's point of view no pb. I guess we can wait for someone who need a TinyMCE support ...

dunglas commented 11 years ago

Ok. I'll do a PR to SonataMediaBundle ASAP.

rande commented 11 years ago

@dunglas any news ?

dunglas commented 11 years ago

@rande I'm very busy right now. I'll do the PR next week, hopefully.

eko commented 10 years ago

Hi @dunglas, if you are ok with that and busy at the moment I can have a look to integrate your code into SonataMediaBundle

dunglas commented 10 years ago

@eko You're welcome.

sroze commented 10 years ago

Was merged.