search

coopTilleuls / CoopTilleulsCKEditorSonataMediaBundle

Integrates SonataMediaBundle for Symfony with CKEditor
http://les-tilleuls.coop
MIT License
53 stars 41 forks source link

Add Compatibility for Symfony 4 #34

Closed dFayet closed 5 years ago

dFayet commented 5 years ago

This PR adds Compatibility for Symfony 4 and should fix issues #32 and #33

I'm not sure if this is the best solution, tell me if you have an other idea. If you are ok with this solution I will update the install doc.

On an other note on sonata-project/admin-bundle 3.40 they have removed the inlined js used in the layout.html.twig, and replaced it with a meta attribute. This make the bundle not working with version > 3.40, do you want us to force to recent version, and update the layout.html.twig? And if yes, should I do it in this PR or in an other?

dunglas commented 5 years ago

Great, thanks. You can force to upgrade to admin-bundle 3.40+, in the same PR.

dFayet commented 5 years ago

Here you go, and doc updated as well.

Edit:I updated the doc to use FOSCkeditor in place of IvoryCkeditor as ivory is no more actively developed

memboc commented 5 years ago

@dFayet please see also this comment https://github.com/coopTilleuls/CoopTilleulsCKEditorSonataMediaBundle/issues/32#issuecomment-454290355

dFayet commented 5 years ago

Hi @memboc this PR fixes your comment.

Using the parameter sonata.media.admin.media.controller allow us to override the sonata-media MediaAdminController, and so we do not need to rewrite the routes manually.

The others points are also corrected.

dFayet commented 5 years ago

@dunglas Is there anything I can do to make this PR mergeable?

sylvainhenry commented 5 years ago

Could someone merge this PR, I need theses changes to upgrade my SF4 project ?

dunglas commented 5 years ago

Thanks @dFayet