search

coopTilleuls / CoopTilleulsCKEditorSonataMediaBundle

Integrates SonataMediaBundle for Symfony with CKEditor
http://les-tilleuls.coop
MIT License
53 stars 41 forks source link

Compability issue with #45

Closed pavemolc-circunomics closed 10 months ago

pavemolc-circunomics commented 10 months ago

When attempting to use this bundle (v2.0.0) with sonata-project/admin-bundle:4.29 - we receive an error:

In MediaAdminExtension.php line 27:
!!                                                                                 
!!    Compile Error: Declaration of CoopTilleuls\Bundle\CKEditorSonataMediaBundle  
!!    \Admin\MediaAdminExtension::configureRoutes(Sonata\AdminBundle\Admin\AdminI  
!!    nterface $admin, Sonata\AdminBundle\Route\RouteCollection $collection) must  
!!     be compatible with Sonata\AdminBundle\Admin\AbstractAdminExtension::config  
!!    ureRoutes(Sonata\AdminBundle\Admin\AdminInterface $admin, Sonata\AdminBundl  
!!    e\Route\RouteCollectionInterface $collection): void                          
!!

due to incompatibility between method signatures. The method should use RouteCollectionInterface instead of RouteCollection and also should have a : void return type.

dunglas commented 10 months ago

Hey @pavemolc-circunomics, could you tell me if the main branch fixes your issue?