search

coopTilleuls / CoopTilleulsForgotPasswordBundle

Provides a "forgot password" complete feature for your API through a Symfony bundle
MIT License
79 stars 25 forks source link

Replace tokenValue by token to unify the parameter name #102

Closed Cruiser13 closed 2 years ago

Cruiser13 commented 2 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? not yet
Fixed tickets #100
License MIT

Basically the same as #101 but with bc compatibility and targeting 1.4

vincentchalamon commented 2 years ago

You just need to fix the tests and then it'll be perfect :ok_hand: Thanks for your contribution!

Cruiser13 commented 2 years ago

@vincentchalamon not sure about the test setup/coverage here. Could you check?

Cruiser13 commented 2 years ago

Closing this as renaming tokenValue to token was not intended as discussed in #100