search

coopTilleuls / CoopTilleulsOvhBundle

OVH SDK integration in Symfony
http://les-tilleuls.coop
29 stars 6 forks source link

OVH SDK v2 + Symfony3 compatibility #5

Closed bpolaszek closed 8 years ago

bpolaszek commented 8 years ago

Hello,

I wanted to plug this bundle to an existing Symfony 2.8 project using Guzzle 6+. Unfortunately the OVH SDK v1 was using Guzzle 3+.

I upgraded to OVH SDK v2, which also uses Guzzle 6+. I also updated composer.json to allow Symfony 3 projects to use this bundle.

NB: This may lead to hard BC breaks, since I never used the OVH v1 and don't know the consequences. However, sending a SMS was a piece of cake, since I followed the original example in the README.md. If you merge this PR, moving to a new major version is recommended.

Have a nice day, Ben

alchy58 commented 8 years ago

Hello,

Thank you for your PR.

Is it possible to use Composer to get the bundle without your PR merged (force your composer.json) or should I use a custom Composer repository after cloning this project ?

dunglas commented 8 years ago

Sorry for the long delay.

Can you fix the Travis config to make it green @bpolaszek? You just need to change the minimum PHP version. Same for composer.json.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling fe97c170ba829c8b2d36f2e9df3975e265127d75 on bpolaszek:master into b8fdecafed3ab3735fbac4c2c4767602a2a4d137 on coopTilleuls:master.

bpolaszek commented 8 years ago

Sure.

dunglas commented 8 years ago

Thank you @bpolaszek

alchy58 commented 8 years ago

Thank you both