search

coopTilleuls / CoopTilleulsSyliusClickNCollectPlugin

Sell and deliver securely during the COVID-19 pandemic!
https://click-n-collect.shop
GNU Affero General Public License v3.0
78 stars 34 forks source link

Overriding Location Entity #11

Closed davidroberto closed 4 years ago

davidroberto commented 4 years ago

Hi,

I believe the Traits ClickNCollectShippingMethod and ClickNCollectShipment should type-hint LocationInterface instead of Location in order to be able to override the Location entity properly?

Example (in Entity/ClickNCollectShippingMethod): public function addLocation(Location $location): void

should be :

public function addLocation(LocationInterface $location): void

dunglas commented 4 years ago

Good catch indeed! I'll fix this.