search

coopTilleuls / CoopTilleulsSyliusClickNCollectPlugin

Sell and deliver securely during the COVID-19 pandemic!
https://click-n-collect.shop
GNU Affero General Public License v3.0
78 stars 34 forks source link

Override SlotAvailable Constraint #34

Closed davidroberto closed 4 years ago

davidroberto commented 4 years ago

Hey,

When overriding the SlotAvailable Constraint (in order to override the error message), the SlotAvailableValidator throw an exception because the validate method checks if the constraint is an instance of SlotAvailable. A better way is to check if it's a SlotAvailableInterface (and implement it in the SlotAvailable constraint), so that the SlotAvailable can be overrided.

Anyway, thanks a lot for this plugin!

thcolin commented 4 years ago

Hello !

Does the changes on PR #39 would solve your issue ?