search

coopTilleuls / CoopTilleulsSyliusClickNCollectPlugin

Sell and deliver securely during the COVID-19 pandemic!
https://click-n-collect.shop
GNU Affero General Public License v3.0
78 stars 34 forks source link

fix: use Doctrine EntityManagerInterface instead of ObjectManager #58

Closed Kocal closed 3 years ago

Kocal commented 3 years ago
Q A
Bug fix? yes
New feature? no
Deprecations? no
Tickets fixes #57

The service sylius.manager.order is already an instance of Doctrine\ORM\EntityManager which already implement Doctrine\ORM\EntityManagerInterface, so everything will be fine I guess: image

EDIT: not sure why the CI is failing, maybe the runner run with PHP 8.x by default and it fails due to this constraint.

stephpy commented 3 years ago

This move is needed by Sylius 1.9.

See point 3 on upgrade documentation

xchopin commented 3 years ago

any updates?

dunglas commented 3 years ago

Good catch, thanks!