search

coopTilleuls / CoopTilleulsSyliusClickNCollectPlugin

Sell and deliver securely during the COVID-19 pandemic!
https://click-n-collect.shop
GNU Affero General Public License v3.0
78 stars 34 forks source link

Chore/plugin update #65

Closed JacquesDurand closed 1 year ago

JacquesDurand commented 1 year ago
Q A
Bug fix? no
New feature? no
Deprecations? no
Tickets fixes #...

This PR is an attempt to continue the work done in #62 and also make the plugin compatible with Sylius 1.12 and Symfony 6

I also integrated a docker-compose.yml including a mysql database for development/contributing purposes. (updated documentation about contributing is missing, I'll add this asap).

I am unsure about any breaking changes, but tests are passing locally and I did not change the original sources.

Any feedback is deeply appreciated and I hope this will help !

JacquesDurand commented 1 year ago

Note: the "fix" I provide for the issue with the Dependency Injection concerning the lock might totally be out of touch as I am not completely confident about locks and their usage in this case. Do not hesitate to tell me if any changes are needed.

romainallanot commented 1 year ago

closed this as merged in #68