fix: npm build need the dist directeory

coopTilleuls / hm-admin

hm-admin is an angular2 component which help you to build backoffice automatically for an hypermedia API

MIT License

7 stars 0 forks source link

fix: npm build need the dist directeory #38

Closed Gregcop1 closed 8 years ago

Gregcop1 commented 8 years ago

Changes proposed in this pull request:

embed the dist directory required for install via npm

Make sure those checkboxes are checked if you want to be reviewed

[x] Your branch should be mergeable on current master
[x] Tests should pass
[x] Linter should pass
[x] Code coverage should stay higher than 90%
[x] Squash your commits to one commit and follow those recommendations about writing good commit message

coveralls commented 8 years ago

Coverage remained the same at 96.226% when pulling 793cfeb109a97c54d8199cdedfbe4deeb7736468 on Gregcop1:hotfix/0.2.2 into eaeb71931cba2601f36ab118be8b8058c08cce3c on coopTilleuls:hotfix/0.2.2.

gorghoa commented 8 years ago

LGTM. I did an npm pack from your branch, then installed the generated package in my app. Got the dist dir and everything. thanks!

There is something cumbersome though (probably out of scope): I had to modify my system config file by adding material2 barrels (I can live with this one) but some hm-admin specifics too (even If I am not using them):

 'hm-admin/dist/app/hm-admin/+home',
 'hm-admin/dist/app/hm-admin/+list',

(probably more linked to the freshly landed sidenav thing)

Gregcop1 commented 8 years ago

Ok @gorghoa can you write an issue about this ? IMO, the index.js in dist file should contain everything and we shouldn't need additional barrels to use it