coopcycle / coopcycle-app

CoopCycle native app
MIT License
151 stars 33 forks source link

Fix: detox setup #1777

Closed vladimir-8 closed 1 week ago

vladimir-8 commented 2 months ago

https://github.com/coopcycle/coopcycle-ops/issues/29

Atala commented 1 week ago

hello

the PR is fine to me, i just have the following questions

vladimir-8 commented 1 week ago

why have a "release" and a "debug" build for detox? shouldnt we just have "release" to simplify things?

To be able to run locally faster. I did not add any new tests yet, will see how that works

vladimir-8 commented 1 week ago

shall we test on more iOS / android versions? I think for Android the last critical issues were happening on specific versions (Android 7?)

Yes! But setting up and running emulators on Github actions is somewhat painful; each run takes at least 30 minutes and often crashes randomly. Let's see if it's usable in the current setup and then try adding more emulators

vladimir-8 commented 1 week ago

i see some comments bout disk usage problem in github runners, is that solved?

I did not see it happening again. But the fix is somewhat hacky, I remove some dev tools that github installs and use Android 9 image, because it’s smaller

      - name: Free Disk Space (Ubuntu)
        uses: jlumbroso/free-disk-space@main
        with:
          # all of these default to true, but feel free to set to
          # "false" if necessary for your workflow
          android: false
          # large-packages: true
          # swap-storage: true