coopcycle / coopcycle-web

Logistics & marketplace platform. Only for worker-owned business.
https://coopcycle.org
Other
571 stars 130 forks source link

stripe api key issue #4548

Closed vladimir-8 closed 3 months ago

vladimir-8 commented 3 months ago

Fixes https://github.com/coopcycle/coopcycle/issues/62

vladimir-8 commented 3 months ago

is it possible to move other configure() calls into this StripeManager class (and maybe make the method private/internal). I see two remainings

These two are different because they use Stripe directly, and I don't want to touch them now

vladimir-8 commented 3 months ago

also maybe rename this method to setStripeClientKeys() or something like this because we have this configure which is very vague + configurePayment, configureCreateIntentPayload which are different things and actually not related to call to stripe

also maybe add a comment on the method : "Please call this before using the Stripe client lib".

done