coopcycle / coopcycle-web

Logistics & marketplace platform. Only for worker-owned business.
https://coopcycle.org
Other
571 stars 130 forks source link

Allow an admin to override tasks' timeslot/date/time while duplicating/creating a delivery order #4613

Open vladimir-8 opened 2 months ago

vladimir-8 commented 2 months ago

In order to allow creating order at the last minute

I want to allow an admin to override tasks' timeslot/date/time while duplicating/creating a delivery order

Whereas currently the admin is subject to the same validation rules as a client

The platform will not allow duplicating an order with the same time slot if the time slot is no longer valid according to the validation rules.

Additional context

https://coopcycle.slack.com/archives/C4UT4DGQ3/p1725985521223659?thread_ts=1718968668.936509&cid=C4UT4DGQ3

Screenshot 2024-09-10 at 10 16 13

Screenshot 2024-09-10 at 10 17 20

HugoLCR commented 2 months ago

Yes ! that's what I want

Paul-Eraman-CoopCycle commented 1 month ago

@Atala did you do this in the new orders form? i think you did

Atala commented 1 month ago

no i did not

the issue is that an admin should always have the "all the choices" date picker and not the timeslot picker ? @vladimir-8

Paul-Eraman-CoopCycle commented 1 month ago

No, more that ANY action that we "force" stores to do, we want to allow an admin to ignore. if an admin wants to program a pickup after a dropoff, they must have some reason, go for it. stores, its them not knowing what they are doing.

so if we could make ALL forced behavior non-obligatory for admins thatd be the goal

Paul-Eraman-CoopCycle commented 1 month ago

time estimate here @Atala @vladimir-8 ?

Atala commented 1 month ago

for the general conversation in needs to happen elsewhere, but keep in mind that validations and limitations are also here as a help for us to write code, code is based on assumptions. for ex that phone numbers are valid so you create a link so the person can call in app. that (maybe ^^) pickup is before dropoff as you dont handle this case in the pricing rule word - doesn't mean some assumptions/validations are bad / shouldn't be changed.

maybe 1 day work?

it is not very clear to me from the issue

Paul-Eraman-CoopCycle commented 1 month ago

Yeah i definitely dont know how that side of things works... Generally i think it looks like we should make a design for this that starts with that side of things