coopdevs / coopdevs-old-web

coopdevs.org content

http://coopdevs.org

2 stars 10 forks source link

82 -circleci-cache #101

Closed cjwilburn closed 4 years ago

cjwilburn commented 4 years ago

Addresses #82

I did a bit of a refactor on the CircleCI config alongside the cache bits.

Here are the new features:

aliases - they're at the top. it was easier for me to remember which cache I was restoring since CircleCI's syntax requires you to name the cache saving and restoration steps identically, regardless of which package manager you're using
~build contexts - mainly because I am used to using build contexts for runtime environment variables that I don't want to expose in the config file. you can get rid of this if it's a bit much.~
branch filters - this enabled me to run the build scripts on a feature branch

Also, if there's no cache to restore on the first run, it doesn't fail the build.

This was a fun one! Feel free to request any further changes here.

cjwilburn commented 4 years ago

I got rid of the contexts, as they are not needed. I tested the refactored workflow on a local branch, and all the steps were successful except the deployment step, because I don't have the proper credentials.

cjwilburn commented 4 years ago

I removed the production build, but kept the branch filter alias, in case someone would want to use it to run linting, testing, etc.

sauloperez commented 4 years ago

Awesome! Thanks a lot for this contribution @cjwilburn!

cjwilburn commented 4 years ago

You're welcome! I'm going to be visiting Spain for the first time in April, so I was especially excited to contribute to this project.

sauloperez commented 4 years ago

That's good to know! If you pass by Barcelona let us know. We'd really like to meet you! Just open an issue in this same repo 😜

El dj., 31 d’oct. 2019, 2:23, Courtney Wilburn notifications@github.com va escriure:

You're welcome! I'm going to be visiting Spain for the first time in April, so I was especially excited to contribute to this project.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/coopdevs/coopdevs.github.io/pull/101?email_source=notifications&email_token=AAF2B2DT5XTGSTHXXFOXZCTQRIXQRA5CNFSM4JFUJ362YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECWIQNY#issuecomment-548177975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF2B2HDK3ZSR6QQVPPZB63QRIXQRANCNFSM4JFUJ36Q .