Remove user checking from invitation show

coopdevs / katuma

ABANDONED - Old Katuma's backend API

http://www.katuma.org

21 stars 9 forks source link

Remove user checking from invitation show #79

Closed andresgutgon closed 8 years ago

andresgutgon commented 8 years ago

WAT

I removed user checking on invitation#show end point. This was raising this issue https://github.com/coopdevs/katuma/issues/78

Finally I decided that is not API responsibility in this case if there is in the UI a user logged. Is better delegate that check to UI application.

I'm doing that in this front end PR: https://github.com/coopdevs/katuma-web/pull/9

Thoughts?

enricostano commented 8 years ago

More than delegating to UI the issue here is that the show action should just respond either with a 200 or 404, given the right parameters. The Bad request branch was just paranoid.

:+1:

andresgutgon commented 8 years ago

Can we merge this? I suppose Travis is not ready. Right?