Closed nflorentin closed 9 months ago
Deployed to staging @sseerrggii @nflorentin 🎉
These are all the changes: https://github.com/coopdevs/timeoverflow/compare/v4.3.0...develop
If you can take a look 👁️ and validate it ✔️, I can prepare the production release tomorrow or during the weekend.
Thank you so much!
By the way @nflorentin, in staging you can use the users defined in our seeds: https://github.com/coopdevs/timeoverflow/blob/develop/db/seeds.rb#L4 to test the app.
I crash staging testing :face_with_head_bandage:
I changed de document (terms and conditions) to validate #712 and when I tried to enter with a new user i saw too_many_redirects error
Also I tried to test #714 uploading SVG file on organization form https://staging.timeoverflow.org/organizations/7/edit and returns error 500. I can not undo it, i tried to restart application but still some pages return error
@sseerrggii I will try to reproduce the 2 problems tomorrow.
Can you send me the svg you uploaded ?
Thanks
Yes, it was a random svg, but exactly was
@sseerrggii I reproduced the problem with organization logo and fix it, I made a new PR.
But I could not reproduce the problem with terms document. What I did was :
I tried to connect to staging and I'm effectively have the infinite redirects loop. I would need staging logs to understand the problem.
@markets for info
Hi @nflorentin @sseerrggii 👋🏼
Just redeployed the SVG error on staging (https://github.com/coopdevs/timeoverflow/commit/5d56ea65756dbc0306dd22f54e9f1f55b466dd1f), but I'm unable to reproduce the "too many redirects" issue neither.
Hi!!
SVG probleme fixed :heavy_check_mark:
I can not reproduce again the problem with terms and conditions, let's approve it! I will ask @danypr92 to grant access to @nflorentin to staging server
Thank you @nflorentin and @markets :1st_place_medal:
Nice! Thanks @sseerrggii 🤝
I'm going to prepare a production release during this weekend 🎉
@nflorentin @sseerrggii v4.4.0
is now live 🚀 https://github.com/coopdevs/timeoverflow/releases/tag/v4.4.0
Thanks @sseerrggii and @markets for your work
Have a nice week-end !
Security fix: do not let client side send the petition status, controller should define it
Improvements: New petition button and destroy member buttons are extracted into a partial and use in organizations/show page.
Bug fix: An admin on an organization A was seeing "edit organization button" on organizations/show page of organization B.
Closes #715