search

coopercenter / cte-trailblazers

MIT License
0 stars 0 forks source link

In 3rd graph, "Earnings & Growth", change "income" to "wages" #8

Closed athena-small closed 2 years ago

athena-small commented 3 years ago

image

afreed2 commented 3 years ago

Graphs and figure labels have been updated in overleaf and in R, still working on saving as object

athena-small commented 3 years ago

@afreed2 : It looks like when you completed your edits, you pushed your changes directly into the main branch of the repo, rather than opening a pull request. Unfortunately, once there are multiple authors working on a code base, this practice becomes a no-no. I had asked @caneale320 to do some other work in parallel (https://github.com/coopercenter/cte-trailblazers/issues/10). Tl;dr: To implement his changes, he had to roll back to an earlier version of the code, reversing your edits.

Please re-submit your code edits on this issue, by opening a new branch, committing your changes to that branch, pushing that branch to github, and then opening a pull request. Thanks.

athena-small commented 2 years ago

@caneale320 : Please make sure the caption on Figure 3 is changed in the dashboard:

"Figure 3: Median 2018 Annual Incomes Wages of occupation in Virginia by Pathway".

This change is already implemented in the label on the plot x-axis: "Median Income Wage of Occupation".