cooperdk / YAPO-e-plus

YAPO e+ - Yet Another Porn Organizer (extended)
https://github.com/cooperdk/YAPO-e-plus
GNU General Public License v3.0
144 stars 15 forks source link

Duplicate function deletes non-duplicates #38

Closed Wimi2 closed 4 years ago

Wimi2 commented 4 years ago

Describe the bug I think the software is checking duplicates wrong or in a wrong order in certain constellations. When it deletes the files from the drive, there is no other version of this file left.

To Reproduce Steps to reproduce the behavior:

  1. Add for example the whole drive "D:\" -> done
  2. Delete D:\ from software without cleaning database. 2.1. Moving some files around.
  3. Add Sub-folder of D:\ instead of whole drive, because more flexible, e.g. "D\sorted".
  4. Run duplicate check

Expected behavior The software recognizes the new added scenes as "duplicates", deleting either the new ones or the old ones, but leaving none in the process, resulting in a data loss.

Recommendation besides looking into the feature again: Safety measure: moving to trash bin instead of deleting them completely.

Here a screenshot of my now empty folder for the lulz. :D

image

cooperdk commented 4 years ago

A fix will be implemented in develop during the weekend. The fix will be done this way:

cooperdk commented 4 years ago

This should now be fixed. Please get the newest development release