search

cooperdk / YAPO-e-plus

YAPO e+ - Yet Another Porn Organizer (extended)
https://github.com/cooperdk/YAPO-e-plus
GNU General Public License v3.0
144 stars 15 forks source link

Small bugs - argv OutOfRange and a typing error #42

Closed randomdude closed 3 years ago

randomdude commented 3 years ago

Hi hi, here's a fix for a couple bugs. Firstly, argc wasn't checked, so if you ran YAPO from wsgi it'd break. Secondly, there's a bad type conversion I hit too, so I fixed that up.

cooperdk commented 3 years ago

Great to see some PRs - thanks for your additions! :-)

cooperdk commented 3 years ago

Gonna need you to explain the changed logging and the logging page (which currently is empty for me)...

The way it worked was that it logged to a file, it now logs to db, which I guess is ok if you can clean the log... But, the change also (supposedly) results in no message in console (personally, I follow what happens in con).

Anyway, I appreciate the PRs and good ideas you have. Just in the case of the logging function I guess the page could just print out the data/yapo-eplus.log file..?

Looking forward to more ideas and inputs, as I mentioned I really appreciate it (and I am sure many others will too).

-cooperdk

(Edit: can see a new file named server.log so I guess it logs to both db and fs?