cooperdk / YAPO-e-plus

YAPO e+ - Yet Another Porn Organizer (extended)
https://github.com/cooperdk/YAPO-e-plus
GNU General Public License v3.0
146 stars 15 forks source link

Issue with the Freeones actor scraper (measurements) #62

Closed cooperdk closed 3 years ago

cooperdk commented 3 years ago

Operation breaks if an actor's measurements only include the first part, for example "32A". For some reason, the parser I wrote fails to recognize if only parts of the measurement field are available.

This issue breaks operation if a new folder is added, and it makes it impossible to re-add the folder because I introduced a feature to not allow a user to add the same folder twice. The only way to remedy this is to manually edit the database.

Therefore, KEEP BACKUPS for now.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Add Folders/Actors/Tags'
  2. Add a new folder
  3. Let YAPO work through the directory structure, allowing it to add new actors.
  4. At some point, you may get this error:

03:07:35 [ERROR] local variable 'measurements' referenced before assignment while trying to add (folder) to folder list

Expected behavior The measurements data should be parsed correctly, and only the first part added if that's the only part available. This worked earlier, but stopped working after I modified the scraper to work with XPATHs.

As this is a bug that will potentially make it impossible to re-add the same folder (without renaming it), this is a priority issue and will be fixed very soon.

cooperdk commented 3 years ago

Fixed 22 Feb 21 commit 8f56724