Prevents unknown props ... on tag

cooperka / react-native-immutable-list-view

:scroll: Drop-in replacement for ListView, FlatList, and VirtualizedList.

MIT License

205 stars 30 forks source link

Prevents unknown props ... on tag #33

Closed jaulz closed 6 years ago

jaulz commented 6 years ago

Currently, the following warnings are printed:

Unknown props immutableData, renderEmpty, rowsDuringInteraction, sectionHeaderHasChanged, renderEmptyInList on <div> tag. Remove these props from the element.
Unknown prop emptyText on <div> tag. Remove this prop from the element.

These changes pass only the necessary props to the components.

Original PR: #29

jaulz commented 6 years ago

Here we go... I hope this makes it easier for you to see what is going on :)

cooperka commented 6 years ago

Thanks @jaulz! There are several instances where you've changed the formatting in addition to changing the logic itself; that makes it a bit harder to see what's actually changed, and I also prefer it to be formatted the old way for readability. Do you mind updating it so that this PR includes the minimal amount of changes to fix the warnings please?

cooperka commented 6 years ago

Wonderful, it looks great now. Thanks again for the effort, it really helps -- not only for my understanding but also for others when they look back at the history of what changed. Will merge :beers:

cooperka commented 6 years ago

Released in v0.7.0