search

cooperka / react-native-immutable-list-view

:scroll: Drop-in replacement for ListView, FlatList, and VirtualizedList.
MIT License
205 stars 30 forks source link

Override keyExtractor in empty lists. #35

Closed Jephuff closed 6 years ago

Jephuff commented 6 years ago

If a custom keyExtractor is passed in, it might be expecting a certain data structure. Because EmptyListView overrides the data structure so it can skip the custom keyExtractor and pass one specific to the empty list.

cooperka commented 6 years ago

Thank you @Jephuff! It's actually just a feature of VirtualizedList, so I've removed the prop from EmptyListView.

Jephuff commented 6 years ago

ahh that makes sense! Thanks! :) Would you be able to publish it to NPM? Unless you are waiting for other stuff in the next version of course.

cooperka commented 6 years ago

Published!

Jephuff commented 6 years ago

Awesome! Thanks!