search

cooperka / react-native-immutable-list-view

:scroll: Drop-in replacement for ListView, FlatList, and VirtualizedList.
MIT License
205 stars 30 forks source link

immutable as dev dependency #7

Closed jamesholcomb closed 7 years ago

jamesholcomb commented 7 years ago

Hi, thanks for the work on this package.

I was curious if it were possible to make immutable a devDependency in your package.json. It seems react-native already specifies it, albeit an older version.

cooperka commented 7 years ago

Hi @jamesholcomb, thanks for the suggestion! I think that should work well. I also want to improve the peerDependencies so there are less npm warnings when using an rc version of React Native. I'll try to get around to both these changes soon, but in the meantime feel free to submit a PR for your suggestion.

cooperka commented 7 years ago

Update: I tried including immutable as a peerDependency, but React Native's version (which happens to be over a year old) has several issues. It prints loads of warnings about deprecated iterable.length, and their version also fails snapshot tests because of the size of the items in ListViewDataSource.

You can see the failing tests here if you're interested. I'm going to have to keep it as an explicit dependency until React Native can upgrade.

Any particular reason you wanted it out of dependencies?

jamesholcomb commented 7 years ago

Nope. That makes sense.