search

cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.
Other
815 stars 150 forks source link

AndroidX Support #112

Closed mrbrentkelly closed 5 years ago

mrbrentkelly commented 5 years ago

This PR updates the android project (and example android project) to support AndroidX.

React Native will support AndroidX once 0.60 is released, so it's important that third party libraries also make the switch.

https://github.com/facebook/react-native/releases/tag/v0.60.0-rc.1 https://github.com/facebook/react-native/issues/23112

Note: I would advise NOT merging this until RN0.60 has been released.

cooperka commented 5 years ago

Much appreciated @mrbrentkelly, I'll merge this once v0.60 is released (feel free to remind me when that happens as I'm not highly active with RN these days).

bhaskarGyan commented 5 years ago

Hi @cooperka , v0.60 is released, Can you please merge

bhaskarGyan commented 5 years ago

Hi @se-bastiaan , @cooperka Should I open a new PR with above changes? Looks like @mrbrentkelly is busy.

cooperka commented 5 years ago

Fantastic work here, thank you all 🎉

Tested and verified on Android and iOS. Will bump major version to 2.0. Much appreciated.