search

cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.
Other
815 stars 150 forks source link

Font Family prop & RTL support for android #117

Closed alijamaliz closed 4 years ago

guvenakcoban commented 4 years ago

Is there any update on that pr? @alijamaliz @cooperka. I just want to use a custom font family.

cooperka commented 4 years ago

Hi @guvenakcoban, I haven't yet had time to fully test this using the new props and RTL language settings, or to document screenshots before/after. I may have time next week around the holidays.

In the meantime, you are welcome to fork this library and merge the PR on your fork so you can use it right away.

cooperka commented 4 years ago

fontFamily support has been cherry-picked to master in https://github.com/cooperka/react-native-snackbar/commit/3994de39cf74195228132cdd7537da74e63461ab. Thank you again @alijamaliz. Demo from the example app:

Screen Shot 2020-01-20 at 18 15 54

I will leave this PR open until RTL changes are also in (I'm planning to cherry-pick those as well, but no guarantees).

cooperka commented 4 years ago

And rtl support has been cherry-picked to master in https://github.com/cooperka/react-native-snackbar/commit/f89d3e8bd13e03d08fa7455e3522d186b1c4ae39. Demo from the example app:

Screen Shot 2020-01-20 at 18 42 16

Source:

Screen Shot 2020-01-20 at 18 43 06

Closing as these changes are now merged.

Released in v2.2.0 🎉