Update README.md with the maximum of characters in title.

cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.

Other

823 stars 152 forks source link

Update README.md with the maximum of characters in title. #119

Closed boceto1 closed 5 years ago

boceto1 commented 5 years ago

Description

The snack bar just allows setting 70 characters, after that it sets three dots. We should consider this for future implementations.

cooperka commented 5 years ago

Thanks for the PR @boceto1. Where is the number 70 coming from? I didn't think there was any hard limit.

boceto1 commented 5 years ago

@cooperka, I updated the description of PR. If you have any comment. Please, let me know.

cooperka commented 5 years ago

Ah, I think it's more accurate to say the text is limited to 2 lines (in most cases), rather than 70 characters. For example, the letter m is much wider than the letter l so you can fit a different number depending on the actual text.

This also depends on the platform; iOS is limited to 2 lines, but Android depends on your config since it uses the native Android Snackbar component. Related: https://github.com/cooperka/react-native-snackbar/issues/110.

I'll update the wording and merge.

boceto1 commented 5 years ago

OK. Thanks