cooperka / react-native-snackbar

:candy: Material Design "Snackbar" component for Android and iOS.
Other
815 stars 150 forks source link

Support margin bottom/left/right for Android #137

Closed NoumanSakhawat closed 3 years ago

NoumanSakhawat commented 4 years ago

Adding Margin for Bottom,Left and Right for Android

How to use: Include an action Button with Margin:

Snackbar.show({ title: "Your Message", left: 8, bottom: 8, right: 8, action: { title: "Dismiss", onPress: () => { / Do something. / Snackbar.dismiss(); } } });

Related to #15

cooperka commented 4 years ago

Hi @NoumanSakhawat, thanks for your contribution. Could you please take some time to match your code style to the style of the project? Keep in mind the following:

As the project maintainer, I use my spare time to review and merge pull requests, and it makes the project easier for me to maintain if the code is clean and consistent. I appreciate it!

HugoGresse commented 3 years ago

I'll love to see this completed, in the meantime, I'm switching to https://github.com/testshallpass/react-native-dropdownalert

cooperka commented 3 years ago

Thanks @HugoGresse, that seems like a good alternative for some cases.

I invite you to help contribute to the community if you need this feature; @NoumanSakhawat has not been responsive for many months so I'm going to close their PRs. I welcome future contributions.